Skip to content

fix: The system prompt for optimizing nodes is ineffective, and the optimization results do not output issues but directly answer the user's questions. #4874 #4878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Mar 16, 2026
+1 −1
Merged

fix: The system prompt for optimizing nodes is ineffective, and the optimization results do not output issues but directly answer the user's questions. #4874 #4878

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/question_node/impl/base_question_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def generate_prompt_question(self, prompt):
return HumanMessage(self.workflow_manage.generate_prompt(prompt))

def generate_message_list(self, system: str, prompt: str, history_message):
if system is None or len(system) == 0:
if system is not None and len(system) > 0:
return [SystemMessage(self.workflow_manage.generate_prompt(system)), *history_message,
HumanMessage(self.workflow_manage.generate_prompt(prompt))]
else:
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the line where len(system) is checked. It should be checking for inequality (!=), not equality (==). Here's the corrected part of the code:

if system is not None and len(system) != 0:

Expand Down
Loading