Skip to content

fix: The system prompt for optimizing nodes is ineffective, and the optimization results do not output issues but directly answer the user's questions. #4874#4878

Merged
shaohuzhang1 merged 1 commit intov2from
pr@v2@fix_question
Mar 16, 2026

Conversation

@shaohuzhang1
Copy link
Contributor

fix: The system prompt for optimizing nodes is ineffective, and the optimization results do not output issues but directly answer the user's questions. #4874

…ptimization results do not output issues but directly answer the user's questions. #4874
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

if system is not None and len(system) > 0:
return [SystemMessage(self.workflow_manage.generate_prompt(system)), *history_message,
HumanMessage(self.workflow_manage.generate_prompt(prompt))]
else:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the line where len(system) is checked. It should be checking for inequality (!=), not equality (==). Here's the corrected part of the code:

if system is not None and len(system) != 0:

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Mar 16, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shaohuzhang1 shaohuzhang1 merged commit 207930b into v2 Mar 16, 2026
3 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_question branch March 16, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant