Skip to content

Fix Chatterbox multilingual diacritic normalization #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
0xShug0 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −3
Open

Fix Chatterbox multilingual diacritic normalization #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/models/chatterbox/text_tokenizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#include "engine/models/chatterbox/text_tokenizer.h"

#include "engine/framework/io/json.h"
#include "engine/framework/text/unicode_normalization.h"
#include "unicode.h"

#include <algorithm>
Expand Down Expand Up @@ -190,12 +191,12 @@ std::string lower_ascii(std::string text) {
return text;
}

std::string lower_and_normalize_nfd(const std::string & text) {
std::string lower_and_normalize_nfkd(const std::string & text) {
auto codepoints = unicode_cpts_from_utf8(text);
for (uint32_t & codepoint : codepoints) {
codepoint = unicode_tolower(codepoint);
}
codepoints = unicode_cpts_normalize_nfd(codepoints);
codepoints = engine::text::normalize_nfkd_codepoints(codepoints);
std::string out;
for (const uint32_t codepoint : codepoints) {
out += unicode_cpt_to_utf8(codepoint);
Expand Down Expand Up @@ -431,7 +432,7 @@ std::vector<int32_t> encode_chatterbox_multilingual_text(
const std::string & language) {
const auto & tokenizer = tokenizer_base;
const std::string normalized_language = normalize_chatterbox_language_code(language);
std::string prepared = lower_and_normalize_nfd(text);
std::string prepared = lower_and_normalize_nfkd(text);
if (normalized_language == "ko") {
prepared = decompose_korean_hangul(prepared);
}
Expand Down
Loading