Fix Chatterbox multilingual diacritic normalization - #468
Open
0xShug0 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #462.
Chatterbox multilingual text preprocessing now uses the framework NFKD decomposition helper instead of the llama tokenizer NFD helper. The previous helper mapped each input codepoint to a single output codepoint, so precomposed diacritics such as Polish accented letters could lose their combining marks before tokenization.
This keeps the fix scoped to Chatterbox multilingual tokenization and does not change the English tokenizer path.
Validation
audiocpp_cli.