Skip to content

Conversation

@shubham-padia
Copy link
Member

Fixes #1087.

Screenshots and screen captures:
Before:
before_dap_tooltip

After:
after_dap_tooltip

Platforms this PR was tested on:

  • Windows
  • macOS
  • Linux (specify distro)
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@timabbott
Copy link
Member

I discussed this change with @andersk and he pointed out that this is desktop app UI and should not be entirely on the user-controlled side of the Line of Death (See e.g., https://emilymstark.com/2022/12/18/death-to-the-line-of-death.html), which this PR moves it to be.

In practice what I think that means is we should have the arrow move left instead, so the arrow overlaps into the avatar box, and have the arrow have a different/shape color where it will have suitable contrast with the UI elements there.

@shubham-padia
Copy link
Member Author

Got it, in this case the original issue would not be valid and we should just close that?

have the arrow have a different/shape color where it will have suitable contrast with the UI elements there.

This seems like a different issue. I'm not sure of the priority here, but my assumption is that it's not high priority.

@alya
Copy link
Collaborator

alya commented Nov 26, 2025

I think @timabbott was suggesting maybe moving this tooltip further left?

Do the other tooltips actually mentioned in the issue actually need to be pulled left to match this one?

@alya
Copy link
Collaborator

alya commented Nov 26, 2025

Not sure any of this is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No spacing between tooltips of organisations.

4 participants