Repository navigation
Conversation
Enterprise Server validates a whole GraphQL document before applying directives, so the listing and summary documents fail there because they name `stack` and `stackEntry`, even under `@include(if: false)`. Enterprise hosts now get documents without those fields, and github.com gets `PullRequestSearchWithStacks` and `PullRequestSummaryWithStacks`, which share one `PullRequestStackFields` fragment with `PullRequestStackMembership`. Co-authored-by: felixlaga <felix.laga@yahoo.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub Enterprise Server, the Pull Requests tab is empty and linked pull request summaries fail with
Field 'stack' doesn't exist on type 'PullRequest'. The listing and summary documents namestackandstackEntryunder@include(if: $stacks). Enterprise Server validates the whole document before it applies directives, so$stacks: falsedoesn't help. This is upstream issuepingdotgg/t3code#20436.This keeps the approach of upstream
#20531, which a maintainer took over and kept: Enterprise hosts get documents without the stack fields, and github.com gets...WithStacksvariants, so github.com makes the same requests as before. Compared with that PR and#31184:PullRequestStackFieldsfragment holds the stack fields. The github.com summary, the github.com search and the existingPullRequestStackMembershipall use it, instead of each having its own copy.hasStacks(host)check replaces the inlinehost === "github.com"at each call.graphql.config.tscomment no longer says to gate Enterprise-missing fields with@include.Validation:
vp run check:changedpasses. The Enterprise test fails onmain, where the search document namesstack. It also fails if every host is sent the stack documents. I didn't run this against a live Enterprise server.The original fix is felixlaga's; the commit credits them as co-author.
Implemented with Claude Opus 5.5 in Claude Code, through T3 Code.