Merged
Conversation
Enable BFC to build successfully on FreeBSD by addressing platform-specific compiler requirements and API differences. Changes: - Add -mcrc32 flag for CRC32 intrinsics on x86_64/amd64 architectures - Detect FreeBSD's 'amd64' architecture identifier (in addition to x86_64/AMD64) - Fix unused parameter warning in bfc_os_advise_nocache() on FreeBSD - Fix benchmark_encrypt.c to use correct reader API (bfc_reader_set_encryption_password) - Update documentation to mention FreeBSD support and pkgconf requirement Technical details: - FreeBSD's Clang requires both -msse4.2 and -mcrc32 for _mm_crc32_* intrinsics - CMAKE_SYSTEM_PROCESSOR returns "amd64" on FreeBSD (not "x86_64") - Changed from set_source_files_properties to target_compile_options for proper flag application Tested on FreeBSD 14.3-RELEASE with Clang 19.1.7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable BFC to build successfully on FreeBSD by addressing platform-specific compiler requirements and API differences.
Changes:
Technical details:
Tested on FreeBSD 14.3-RELEASE with Clang 19.1.7.