fix: include exact in MongoDB search_param - #852
Open
daviddallakyan2005 wants to merge 2 commits into
Open
Conversation
search_embedding indexes search_params["exact"] on every query, but search_param() only returned num_candidates_ratio, so MongoDB search crashed with KeyError. Default remains False (ANN).
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: daviddallakyan2005 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Mock collection.aggregate so ANN vs exact pipelines and a missing exact key are covered; pymongo is stubbed when the extra is absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MongoDB search crashes on every query with
KeyError: 'exact'.search_embeddingindexessearch_params["exact"], butMongoDBIndexConfig.search_param()only returnednum_candidates_ratio.This adds
exact: bool = Falseand emits it fromsearch_param(), and reads the key with.get("exact"). The default stays ANN (numCandidates);exact=Trueenables Atlas$vectorSearchENN.How to test
CI
make unittestis a single network download and will not run this file.pip install -e '.[test]' make lint PYTHONPATH=. python3 -m pytest tests/test_mongodb_config.py -q