feat(adbpg): add ADBPG generic search configuration - #832
Open
swhhy wants to merge 18 commits into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: swhhy The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign @XuanYang-cn |
yhmo
reviewed
Aug 4, 2026
yhmo
reviewed
Aug 4, 2026
yhmo
reviewed
Aug 4, 2026
Added new tests for index build options and autotuning behavior in Adbpg.
Added regex patterns for numeric and array expressions in autotune configuration. Implemented validation for autotune parameters and added methods for handling autotune target recalls and progress monitoring.
Removed the benchmark_topk field and added new fields for index build options and autotune parameters.
Added configuration for Cohere-1M benchmark with autotune settings.
Added a field validator for index_build_includes to ensure no empty columns are included and to normalize the column names.
Added support for including additional columns in index creation.
Updated assertions in test cases to use correct syntax and added a new test for index build includes.
Updated help text for autotune arguments to clarify usage.
Removed ADBPG NOVA autotune configuration for topK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds generic search configuration support for the ADBPG client. Many thanks to the maintainers for taking the time to review and merge this contribution. Your feedback and support are greatly appreciated.