Chore: Add select query into application#454
Merged
zigzagdev merged 6 commits intochore/add-main_iamge_urlfrom May 5, 2026
Merged
Chore: Add select query into application#454zigzagdev merged 6 commits intochore/add-main_iamge_urlfrom
zigzagdev merged 6 commits intochore/add-main_iamge_urlfrom
Conversation
Adds an optional ?string $mainImageUrl constructor parameter and a getMainImageUrl() getter so downstream layers can read the raw main_image_url straight from the DTO. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reads main_image_url from the input array and forwards it to the WorldHeritageDto constructor so detail-path callers carry the value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reads main_image_url from the input array and forwards it to the WorldHeritageDto constructor so list/summary callers carry the value. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…thumbnail Updates WorldHeritageViewModel::getThumbnailUrl to fall back as main_image_url ?? images[0]?->url ?? null so the exposed thumbnail_url reflects the new field. The view model summary test mock is updated to cover the new path via getMainImageUrl. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Renames the existing 'thumbnail' summary key to 'thumbnail_url' and fills it with main_image_url ?? images[0]?->url ?? null so the list endpoint surfaces the new field with the same fallback semantics as the detail ViewModel. The collection summary test is updated to assert the new key name. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
WorldHeritageViewModelCollectionFactoryTest used to seed the legacy imageUrl ImageDto field from thumbnail_url. The view model now resolves thumbnail_url via main_image_url ?? images[0]?->url, so the mock is updated to pass mainImageUrl directly. Drops the now-unused ImageDto import. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.