Start replacing assertions with descriptive TypeErrors

Author: puddly

zigpy_znp/types/basic.py

@@ -132,7 +132,11 @@ class TypedListMeta(list):
     _length = None
 
     def serialize(self) -> bytes:
-        assert self._length is None or len(self) == self._length
+        if self._length is not None and len(self) != self._length:
+            raise ValueError(
+                f"Invalid length for {self!r}: expected {self._length}, got {len(self)}"
+            )
+
         return b"".join([self._item_type(i).serialize() for i in self])
 
     @classmethod

zigpy_znp/types/commands.py

@@ -385,7 +385,7 @@ def to_frame(self):
                 f"Cannot serialize a partial frame: missing {missing_params}"
             )
 
-        data = b"".join(v.serialize() for p, v in self._bound_params.values())
+        data = b"".join([v.serialize() for p, v in self._bound_params.values()])
 
         return GeneralFrame(self.header, data)