Remove unnecessary NVRAM overflow checks, it's not that low-level

Author: puddly

tests/test_api.py

@@ -618,10 +618,6 @@ async def test_znp_nvram_writes(znp, event_loop):
 
     znp._uart.send.reset_mock()
 
-    # Writing too big of a value should fail
-    with pytest.raises(ValueError):
-        await znp.nvram_write(nvids.NwkNvIds.STARTUP_OPTION, t.uint16_t(0xAABB))
-
     # The SYS_OSAL_NV_WRITE response status should be checked
     event_loop.call_soon(
         znp.frame_received,

zigpy_znp/api.py

@@ -347,23 +347,6 @@ async def nvram_write(
         if not isinstance(value, bytes):
             value = value.serialize()
 
-        # Find the next NVID in the table to check that our write doesn't overflow
-        # It's not foolproof, but it will catch simple mistakes
-        all_enum_values = list(type(nv_id))
-        all_enum_values.sort(key=lambda i: i.value)
-        index = all_enum_values.index(nv_id)
-
-        if index == len(all_enum_values) - 1:
-            LOGGER.warning(
-                "NVID is at end of table, cannot check for overflow"
-            )  # pragma: no cover
-        else:
-            next_nvid = all_enum_values[index + 1]
-            end_address = nv_id + offset + len(value)
-
-            if end_address > next_nvid:
-                raise ValueError("OSALNVWrite request overflows into %s", next_nvid)
-
         return await self.request(
             SysCommands.OSALNVWrite.Req(
                 Id=nv_id, Offset=offset, Value=t.ShortBytes(value)