This is fix for Zig developement branch that changed Allocator interface #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the zstbi Zig library to be compatible with the development version of Zig 0.15, which introduced breaking changes to the Allocator interface. The changes specifically address the new alignment handling in Zig's memory allocation system.
- Updates memory alignment constant from integer literal to the new
std.mem.Alignmenttype - Modifies alignment usage in memory operations to use the new
.toByteUnits()method - Updates minimum Zig version requirement and project version metadata
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/zstbi.zig | Updates memory alignment constant and alignment usage in allocator functions |
| build.zig.zon | Updates minimum Zig version requirement to 0.15.0-dev |
| .zigversion | Updates project Zig version from 0.14.0 to 0.15.0-dev |
| var mem_allocations: ?std.AutoHashMap(usize, usize) = null; | ||
| var mem_mutex: std.Thread.Mutex = .{}; | ||
| const mem_alignment = 16; | ||
| const mem_alignment = std.mem.Alignment.@"16"; |
There was a problem hiding this comment.
[nitpick] The quoted identifier syntax @"16" is unnecessary here. Use the cleaner syntax: std.mem.Alignment.from(16) or std.mem.Alignment.of(16) if available in Zig 0.15.
Member
|
Resolved by #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this changes it doesn't compile with developement version of Zig-0.15