Clean up before continuing with wrapper implementation #27
+1,397
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bindings.zig` changes: * used literals instead of variables for enums in OpenGL 4.2, * moved `DEBUGPROC` to the beginning of OpenGL 4.3, * adjusted wrong enum name from `VIEW_CLASS_RGTC1_RG` to `VIEW_CLASS_RGTC2_RG` in OpenGL 4.3, * added missing enums to OpenGL 4.4, * removed enum `TEXTURE_BINDING` from OpenGL 4.5, * changed ARB enums to non-ARB ones in OpenGL 4.5, * added missing enums to OpenGL 4.5, * added `POLYGON_OFFSET_CLAMP` to OpenGL 4.6, * added spacing between sections. `wrapper.zig` changes: * added changes from merge zig-gamedev#25 to wrapper placeholders, * applied enum changes done in `bindings.zig`, * moved `DEBUGPROC` to the beginning of OpenGL 4.3, * added many missing enums to OpenGL 4.3, * added missing function placeholders to OpenGL 4.3, * added missing function placeholders to OpenGL 4.5, * return type of `getGraphicsResetStatus` uses non-ARB enums in OpenGL 4.5, * added spacing between sections.
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive cleanup of OpenGL bindings and wrapper code to improve consistency and completeness across OpenGL versions 4.2 through 4.6.
- Uses literal values instead of constant references for OpenGL 4.2 enums
- Reorganizes and completes enum definitions across OpenGL 4.3-4.6
- Updates function signatures to use consistent pointer types (
[*c]instead of[*]or single pointers) - Adds missing enums and function placeholders for better API coverage
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/bindings.zig | Updated enum definitions to use literals in OpenGL 4.2, fixed VIEW_CLASS_RGTC2_RG enum name, moved DEBUGPROC to beginning of OpenGL 4.3, added missing enums to OpenGL 4.4-4.6, added spacing between sections |
| src/wrapper.zig | Applied corresponding enum and function signature changes from bindings, reorganized OpenGL 4.3 enums and added many missing ones, added missing function placeholders for OpenGL 4.3 and 4.5, updated getGraphicsResetStatus to use non-ARB enum names, improved spacing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bindings.zigchanges:DEBUGPROCto the beginning of OpenGL 4.3,VIEW_CLASS_RGTC1_RGtoVIEW_CLASS_RGTC2_RGin OpenGL 4.3,TEXTURE_BINDINGfrom OpenGL 4.5,POLYGON_OFFSET_CLAMPto OpenGL 4.6,wrapper.zigchanges:bindings.zig,DEBUGPROCto the beginning of OpenGL 4.3,getGraphicsResetStatususes non-ARB enums in OpenGL 4.5,