Skip to content

fix(ci): don't let the clean no-credentials scan result abort the release #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zero2005x merged 1 commit into from
Oct 1, 2026
Merged

fix(ci): don't let the clean no-credentials scan result abort the release #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,14 +208,18 @@ jobs:
# only, so a release artifact must never contain them. This scans exactly
# what is about to be published. Exit code 2 means "nothing configured to
# look for", which is the expected state in CI and not a failure.
#
# Steps run under `bash -e`, so the exit code must be captured with `|| rc=$?`.
# A bare call followed by `rc=$?` aborts the step on the script's exit 2 and
# the `case` below is never reached.
run: |
failed=0
for artifact in dist/*.apk dist/*.aab; do
bash scripts/verify-bundle-secrets.sh "$artifact"
rc=$?
rc=0
bash scripts/verify-bundle-secrets.sh "$artifact" || rc=$?
case "$rc" in
0|2) ;; # 0 = clean, 2 = no credentials configured
*) failed=1 ;;
*) echo "::error::$artifact failed the Rokid credential scan (rc=$rc)"; failed=1 ;;
esac
done
exit $failed
Expand Down
Loading