ci: fail if PR title is auto-generated from branch name #99843
+31
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Prevent auto-generated PR titles: - Prevents cryptic titles: No more auto-generated titles like "Fix bug 123" - Encourages meaningful descriptions: Forces authors to write descriptive titles - Improves searchability: Better titles make PRs easier to find later - Better release notes: Meaningful titles improve changelog quality Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/ci/autogenerate_title
branch
from
c4bd6d8 to
561a04a
Compare
|
Comment on lines
+111
to
+113
| if pr_title in potential_auto_titles or pr_title.lower() in [ | ||
| t.lower() for t in potential_auto_titles | ||
| ]: |
Member
There was a problem hiding this comment.
how about doing lower() on branch_name and pr_title above, then you'd get away with a single match here rather than this pycrobatics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent auto-generated PR titles:
123"
descriptive titles
Signed-off-by: Anas Nashif anas.nashif@intel.com