drivers: comparator: microchip: Introduce G1 Comparator Driver #99155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NhMchp
added
platform: Microchip SAM
ArunMCHP
force-pushed
the
g1_comparator_driver
branch
2 times, most recently
from
db18193 to
6dd0b20
Compare
zephyrbot
added
area: Boards/SoCs
platform: Microchip MEC
zephyrbot
requested review from
VenkatKotakonda,
albertofloyd,
bjarki-andreasen,
jvasanth1,
nandojve,
nashif,
pdgendt and
stephanosio
nandojve
requested changes
Nov 10, 2025
ArunMCHP
force-pushed
the
g1_comparator_driver
branch
from
6dd0b20 to
bd31383
Compare
NhMchp
previously approved these changes
Nov 11, 2025
bjarki-andreasen
requested changes
Nov 11, 2025
tests/drivers/comparator/gpio_loopback/boards/sam_e54_xpro.overlay
Outdated
Show resolved
Hide resolved
ArunMCHP
force-pushed
the
g1_comparator_driver
branch
from
bd31383 to
6e548d0
Compare
NhMchp
previously approved these changes
Nov 13, 2025
nandojve
previously approved these changes
Nov 13, 2025
Add the device tree node and the binding file for microchip comparator G1 Peripheral. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
Add G1 Comparator driver for Microchip Analog Comparator Peripherals. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
Update sam_e54_xpro.yml to include Comparator in the supported features list. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
Add board overlay file for sam_e54_xpro to enable comparator test cases to run on this board. Signed-off-by: Arunprasath P <arunprasath.p@microchip.com>
ArunMCHP
dismissed stale reviews from nandojve, NhMchp, and bjarki-andreasen
via
4f7bdf7
ArunMCHP
force-pushed
the
g1_comparator_driver
branch
from
6e548d0 to
4f7bdf7
Compare
|
Contributor
Author
|
Hi @bjarki-andreasen, @nandojve, @NhMchp, I have resolved the conflicts in the PR. Could you please re-approve the PR? |
bjarki-andreasen
approved these changes
Nov 14, 2025
NhMchp
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Comparator driver support for the Microchip Analog Comparator peripheral. It introduces the Comparator driver implementation and updates the devicetree for the SAM D5x/E5x series to include the required node and bindings.