dts: arm: st: n6: fixup adc2 missing properties #99151
Conversation
The added stm32-adc properties in c21cdd8 ("dts: bindings: adc: stm32: add new properties to simplify the driver") were missing from adc2 within the stm32n6.dtsi. Since adc1 and adc2 are almost identical, just copy the missing properties from adc1 which was fixed up as part of 5f0c63e ("dts: arm: st: fill out adc nodes with the new properties"). This fixes compilation when using adc2: ``` devicetree error: 'st,adc-internal-regulator' is marked as required in 'properties:' in [...]/zephyr/dts/bindings/adc/st,stm32n6-adc.yaml, but does not appear in <Node /soc/adc@50022100 in [...]/zephyr/dts/arm/st/n6/stm32n6.dtsi:456> ``` Signed-off-by: Emil Dahl Juhl <emil@s16s.ai>
zephyrbot
requested review from
FRASTM,
GeorgeCGV,
djiatsaf-st,
erwango,
etienne-lms,
gautierg-st,
juickar and
mathieuchopstm
|
|
@cfriedt, @jhedberg Not a release blocker per se, but we'll need it in v4.3.x eventually. Do you prefer it as a backport ? @Emil-Juhl In any case, a mtaching issue will be required. Would you mind creating it ? |
|
|
Since this is fixing a build failure, it could be argued that the referenced issue can be classified as a release blocker |
|
Is there some CI test case that fails to build because of this? |
gautierg-st
left a comment
gautierg-st
left a comment
There was a problem hiding this comment.
Oops, my bad, I missed this ADC somehow when adding the new properties. Thanks for the fix.
I don"t think so, but compilation will break on users trying to enable adc2 (which is not done in the tree today). |
cfriedt
added
bug
|
Added the missing bug label and milestone. I think this can safely be categorized as a release blocker; the platform was added in this release and the linked issue shows it would be broken. Also, since the fix is so extremely localized to one board's dts, it's low risk. I'm fine to merge it. |
7 participants
The added stm32-adc properties in c21cdd8 ("dts: bindings: adc: stm32: add new properties to simplify the driver") were missing from adc2 within the stm32n6.dtsi.
Since adc1 and adc2 are almost identical, just copy the missing properties from adc1 which was fixed up as part of 5f0c63e ("dts: arm: st: fill out adc nodes with the new properties").
This fixes compilation when using adc2:
Fixes #99158