Skip to content

feat: Add support for haskell-debugger#33

Open
rajcspsg wants to merge 1 commit into
zed-extensions:mainfrom
rajcspsg:haskell-debugger-support
Open

feat: Add support for haskell-debugger#33
rajcspsg wants to merge 1 commit into
zed-extensions:mainfrom
rajcspsg:haskell-debugger-support

Conversation

@rajcspsg

@rajcspsg rajcspsg commented May 11, 2026 •
edited
Loading

Copy link
Copy Markdown

closes #12

screen recording for debugger support

@cla-bot

cla-bot Bot commented May 11, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Rajkumar Natarajan.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@rajcspsg rajcspsg force-pushed the haskell-debugger-support branch from c4bf776 to a7133e9 Compare May 11, 2026 02:26
@cla-bot

cla-bot Bot commented May 11, 2026

Copy link
Copy Markdown

We require contributors to sign our Contributor License Agreement, and we don't have @rajcspsg on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@rajcspsg

rajcspsg commented May 11, 2026

Copy link
Copy Markdown
Author

@cla-bot check

@cla-bot cla-bot Bot added the cla-signed label May 11, 2026
@cla-bot

cla-bot Bot commented May 11, 2026

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@MrSubidubi MrSubidubi changed the title issue-12: added support for haskell-debugger Add support for haskell-debugger May 11, 2026
MrSubidubi
MrSubidubi previously approved these changes May 11, 2026
View reviewed changes

@MrSubidubi MrSubidubi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Preliminary review, will do my best to get back to this in a timely manner again

Comment thread src/language_server.rs
Comment thread extension.toml Outdated
name = "Haskell"
description = "Haskell support."
version = "0.2.1"
version = "0.2.2"

@MrSubidubi MrSubidubi May 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ci will lint this, but that will be done after automatically (and will be minor at least)

Comment thread src/debugger.rs Outdated
Comment thread src/debugger.rs Outdated
rajcspsg
rajcspsg commented May 11, 2026
View reviewed changes
Comment thread Cargo.lock Outdated
@rajcspsg

rajcspsg commented May 11, 2026

Copy link
Copy Markdown
Author

@MrSubidubi incorporated your review comments

@brandonchinn178 brandonchinn178 mentioned this pull request Jun 8, 2026
Open
@MrSubidubi

MrSubidubi commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Will try to get back to you with a final review this week, apologies for the delay!

sectore
sectore approved these changes Jun 21, 2026
View reviewed changes

@sectore sectore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. Just tested it on my local machine and it works great.

Tested manually with:

ghc --version
The Glorious Glasgow Haskell Compilation System, version 9.14.1

hdb --version
Haskell Debugger, version 0.13.1.0

zeditor --version
Zed 1.6.3

Just few nits have been added from my side.

Comment thread src/debugger.rs Outdated
Comment thread src/debugger.rs Outdated
Comment thread src/debugger.rs Outdated
Comment thread src/debugger.rs
Comment thread src/language_server.rs Outdated
Comment thread src/language_server.rs
Comment thread Cargo.toml Outdated
sectore
sectore reviewed Jun 21, 2026
View reviewed changes
Comment thread src/debugger.rs Outdated
@sectore

sectore commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Will try to get back to you with a final review this week, apologies for the delay!

@MrSubidubi Any chance for another review? Pls consider latest review comments.

cc/ @rajcspsg

@cla-bot

cla-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: rajcspsg.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot Bot removed the cla-signed label Jun 23, 2026
@rajcspsg rajcspsg force-pushed the haskell-debugger-support branch from 6214232 to f302103 Compare June 23, 2026 06:16
@cla-bot cla-bot Bot added the cla-signed label Jun 23, 2026
@rajcspsg rajcspsg force-pushed the haskell-debugger-support branch 2 times, most recently from 25135a9 to 4bba209 Compare June 23, 2026 06:27
sectore
sectore suggested changes Jun 23, 2026
View reviewed changes

@sectore sectore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33 (comment)

@sectore

sectore commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

@rajcspsg Pls merge latest main.

@rajcspsg rajcspsg force-pushed the haskell-debugger-support branch from 60b325f to 47b2878 Compare July 1, 2026 03:40
@rajcspsg
issue-12: added support for haskell-debugger
9d2c390 
Update src/debugger.rs

Co-authored-by: Finn Evers <finn.evers@outlook.de>

incorporate the review comments

fix github actions

incorporated the review comments

Add debugger module in haskell.rs

rebased with upstream

removed unnessary files
@rajcspsg rajcspsg force-pushed the haskell-debugger-support branch from 47b2878 to 9d2c390 Compare July 1, 2026 03:45
@rajcspsg

rajcspsg commented Jul 1, 2026

Copy link
Copy Markdown
Author

@rajcspsg Pls merge latest main.

@sectore I rebased the PR with upstream main.

@sectore

sectore commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@MrSubidubi Any chance for a final review? Also for PRs #40 / #41 ? Thanks!

@rajcspsg rajcspsg changed the title Add support for haskell-debugger feat: Add support for haskell-debugger Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrSubidubi MrSubidubi MrSubidubi left review comments
+1 more reviewer
@sectore sectore sectore approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add debug adapter for haskell-debugger

3 participants

@rajcspsg @MrSubidubi @sectore