Repository navigation
perf: avoid per-chunk dtype checks in BytesCodec decoding - #4517
Open
victorwon2001 wants to merge 1 commit into
Open
victorwon2001 wants to merge 1 commit into
victorwon2001 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4517 +/- ##
=======================================
Coverage 94.71% 94.72%
=======================================
Files 94 94
Lines 13663 13659 -4
=======================================
- Hits 12941 12938 -3
+ Misses 722 721 -1
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate per-chunk
HasEndiannessandStructtype checks fromBytesCodec._decode_sync. The stored-byte view now uses the native NumPy dtype withnewbyteorder(self.endian)whenever an endian is set, and uses the unchanged dtype otherwise. Byte-swapping, shape restoration and prototype-selected buffers remain intact; the public API and CPU/CUDA abstraction are unchanged.For reviewers
The change is intended to preserve existing data and byte-order semantics. Direct and store-backed tests now cover integers and floats of multiple widths, mixed-endian structured fields, one-byte data, raw bytes, zero-copy matching-endian decoding and copying only for byte-order conversion. An alternating CPU benchmark found lower per-chunk scalar overhead and similar structured performance; the focused tests and full lint passed, while CUDA could not be checked locally.
Author attestation
TODO
docs/user-guide/*.mdchanges/Fixes #3703