fix: auto-open ZipStore in list(), list_dir() and exists()#3855
Open
nuglifeleoji wants to merge 1 commit intozarr-developers:mainfrom
Open
fix: auto-open ZipStore in list(), list_dir() and exists()#3855nuglifeleoji wants to merge 1 commit intozarr-developers:mainfrom
nuglifeleoji wants to merge 1 commit intozarr-developers:mainfrom
Conversation
ZipStore._get() and ._set() already auto-open the zip file when called without a prior open(). Apply the same pattern to list(), list_dir(), and exists() so that all store methods behave consistently when the store has not been explicitly opened. Closes zarr-developers#3846 Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3855 +/- ##
=======================================
Coverage 92.89% 92.90%
=======================================
Files 86 86
Lines 10689 10695 +6
=======================================
+ Hits 9930 9936 +6
Misses 759 759
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
ZipStore._get()and._set()guard against the store not being open:But
list(),list_dir(), andexists()accessself._zfdirectly and crash with anAttributeErrorwhen called beforeopen()(see #3846).This PR applies the same auto-open pattern to those three methods so all store operations behave consistently.
A regression test in
test_zip.pycovers the three methods being called on an unopened store.Closes #3846
Made with Cursor