feat: make alert messages in issues more useful#91
Open
dbartholomae wants to merge 7 commits intozaproxy:masterfrom
Open
feat: make alert messages in issues more useful#91dbartholomae wants to merge 7 commits intozaproxy:masterfrom
dbartholomae wants to merge 7 commits intozaproxy:masterfrom
Conversation
This allows to export and test them individually Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
Signed-off-by: Daniel Bartholomae <daniel@bartholomae.name>
dbartholomae
force-pushed
the
make_alert_messages_in_issuer_more_useful
branch
from
f587cfd to
2aef6ad
Compare
Contributor
Author
|
@psiinon tagging you here as I can't assign reviewers |
Contributor
Author
|
The first commit, Extract action helpers into functions, moves around a lot of code, so I recommend reviewing that commit separately and then reviewing the other commits. They are written so that you can also review them individually, but that might not be needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves the first step of #44 and is a reimplementation of #43 in the new TypeScript setup.
The reason why I pushed it in now is that without a version-number-increasing PR, there won't be an automatic release of this package, and I can't add it to the downstream GitHub actions. The "feat" in the PR title means that when this PR is merged, it will bump the version from 0.2.0 to 0.3.0 and automatically release it to npm.