feat: EBS Volumes tags inherit from labels #3123
Open
tcondeixa wants to merge 5 commits into
Open
Conversation
5 tasks
Collaborator
Author
|
As an option we can make the config more generic with the possibility to extend it later (e.g. aws_tags_inherit_labels), so the labels can be extended to other aws resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is another approach to solve the same problem as #3124
ebs_tags_inherit_labelsconfig option to propagate labels to EBS volume tagsDescribeVolumes) —CreateTagsis only called when a tag is missing or has changed valuepopulateVolumeMetaDatain bothmixedandebsstorage resize modesebs_tags_inherit_labelsthat are not in the PostgreSQL CR and are in the EBS tags are removedNOTE: This requires to add
ec2:CreateTagsandec2:DeleteTagsto the operator IAM role policyConfiguration
Test plan
Co-Authored-By: Claude Sonnet 4.6
Signed-off-by: tcondeixa tscondeixa@gmail.com