document changed configmap default#3116
Conversation
FxKu
moved this from WIP / currently reviewed
to Good state for merge
in Postgres Operator
|
👍 |
| } | ||
| if c.OpConfig.KubernetesUseConfigMaps == nil { | ||
| return true | ||
| } |
There was a problem hiding this comment.
since it's now a *bool type, the option can be nil and should then default to true
| } | ||
| }() | ||
|
|
||
| if !c.patroniKubernetesUseConfigMaps() { |
There was a problem hiding this comment.
so we work everywhere with the operator config c.OpConfig.KubernetesUseConfigMaps but here refer to the Patroni one ?
There was a problem hiding this comment.
it includes an extra check patroniUsesKubernetes
| expectedValuesS3Bucket := []ExpectedValue{ | ||
| { | ||
| envIndex: 15, | ||
| envIndex: 16, |
There was a problem hiding this comment.
which change triggered the renumbering of the env vars ?
There was a problem hiding this comment.
KUBERNETES_USE_CONFIGMAPS env var is now present in unit tests
| @@ -0,0 +1,17 @@ | |||
| <h1>Migrate from v1 to v2</h1> | |||
There was a problem hiding this comment.
that needs a bigger announcement than just a doc.
There was a problem hiding this comment.
my plan is to fill this document with more sections and then link it from the README
|
|
||
| If your current operator deployment is relying on K8s endpoints (the default setup) for Patroni to manage the HA state you have to start planning to switch to configmaps, because endpoints are deprecated from K8s 1.33 onwards. The default of the corresponding parameter `kubernetes_use_configmaps` is changing to `true` with v2.0 of the operator. This means you have to explicity set it to `false` in your configuration if you haven't done it yet before you start the upgrade. | ||
|
|
||
| We explicitly warn you to go straight to configmap-based HA management with database clusters that use replicas, because there's is a danger to run into split-brain scenarios during the rolling update of pods. To play it safe, here is what you should do - before or after the Postgres Operator upgrade: |
There was a problem hiding this comment.
why and under which conditions ?
2 participants
the default of
kubernetes_use_configmapsoptions was silently set to true in #3102 but as a direct change of this config can have severe consequences we need to provide a guide how to migrate to the new setup - from deprecated endpoints to config mapscloses #2946, #3056