return function added #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zakeer
requested changes
Mar 17, 2023
| @@ -0,0 +1,45 @@ | |||
| function arthamaticopeartions(operations){ | |||
Owner
There was a problem hiding this comment.
always remember to use camelCase naming convention for variables/functions name
replace arthamaticopeartions to arithmeticOpeartions
| @@ -0,0 +1,45 @@ | |||
| function arthamaticopeartions(operations){ | |||
Owner
There was a problem hiding this comment.
And one more thing parameter name should be operation not operations
because we just pass a single operator. So if we define operations then it will confuse the user
for a single operator, then parameter should be operation
for multiple operator, then parameter should be operations
Comment on lines
27
to
31
| const addfunction = arthamaticopeartions('+'); | ||
| const multiplyfunction = arthamaticopeartions('*'); | ||
| const subractfunction = arthamaticopeartions('-'); | ||
| const divisionfunction = arthamaticopeartions('/'); | ||
| const modulefunction = arthamaticopeartions('%'); |
Owner
There was a problem hiding this comment.
Here also using camelCase naming conventions for function names
Author
|
ok anna i will change and commit it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.