Conversation
There was a problem hiding this comment.
Pull request overview
Adds a Trunk-based code quality CI pipeline to the zunit repository, configuring conservative formatters/linters (actionlint, yamllint, markdownlint, prettier, gitleaks, git-diff-check) and wiring them to the org-level reusable Trunk workflow. Minimal README cleanup is included to satisfy the new formatter baseline.
Changes:
- Introduce
.trunk/configuration (trunk.yaml, yamllint, markdownlint, gitignore) and a.prettierignorebaseline. - Add
.github/workflows/trunk-check.ymlinvoking the sharedz-shell/.githubTrunk workflow on push/PR/schedule. - Apply minor README formatting to comply with the new formatter rules.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Reformat code block indentation, remove a blank line, and switch a * list marker to -. |
| .trunk/trunk.yaml | Define Trunk CLI version, enabled/disabled linters, runtimes, and actions. |
| .trunk/configs/.yamllint.yaml | Yamllint baseline extending default with a few relaxed rules. |
| .trunk/configs/.markdownlint.yaml | Markdownlint baseline disabling a number of rules. |
| .trunk/.gitignore | Ignore Trunk local state directories. |
| .prettierignore | Exclude legacy docs and .travis.yml from Prettier. |
| .github/workflows/trunk-check.yml | Caller workflow delegating to the org reusable Trunk workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #6.
Verification
trunk check --all --no-fix --no-progress→✔ No issuesgit diff --check.trunk/trunk.yaml,.trunk/configs/*.yaml,.github/workflows/trunk-check.yml./build.zsh >/dev/null && PATH="$tmpbin:$PATH" ./zunit --tap tests→ 108/108 passingTrunk Code Quality / Trunk Code Quality→ passzsh-n→ passzunit→ pass