fix(cli): tidy init help and test isolation#3
Merged
Conversation
dce9444 to
1957564
Compare
There was a problem hiding this comment.
Pull request overview
Small follow-up cleanup addressing review notes from PR #2 that still apply on main, plus a yamllint/Prettier reconciliation needed after the release workflow landed.
Changes:
- Remove the spurious
--versionentry fromzunit init --helpoutput and assert its absence in the help test. - Make the missing-config CLI test self-contained by stubbing
revolverandcolorand pinningPATHinstead of relying on host binaries. - Relax yamllint's
comments.min-spaces-from-contentto1to match Prettier's output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/commands/init.zsh | Drops the misleading -v, --version line from the init usage text. |
| tests/cli.zunit | Stubs revolver/color and overrides PATH for the no-config test; adds negative assertion for --version in init help. |
| .trunk/configs/.yamllint.yaml | Adds comments.min-spaces-from-content: 1 to align with Prettier formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--versionentry fromzunit init --helpWhy
PR #2 surfaced a few useful review notes after its substantive work had already been superseded by PR #1. Two still apply on current
main:init --helpadvertises a global flag as if it were init-specific, and one CLI test relies on ambient host dependencies.While rebasing onto current
main, Trunk also exposed a formatter/linter config mismatch introduced by the newer release workflow: Prettier emits one space before an inline YAML comment, while yamllint's default expected two. The config now accepts Prettier's output instead of forcing a formatter conflict.Verification
PATH="$tmpbin:$PATH" ./zunit --tap tests/cli.zunit tests/reports.zunit→ 10/10 passingPATH="$tmpbin:$PATH" ./zunit --tap tests→ 112/112 passingzsh -n src/commands/init.zsh tests/cli.zunittrunk check --all --no-fix --no-progress→✔ No issues.trunk/configs/.yamllint.yamland.github/workflows/release.ymlgit diff --check