ci: pin checkout SHA; explicitly checkout z-shell/zd in reusable workflow#65
Open
ss-o wants to merge 1 commit into
Open
ci: pin checkout SHA; explicitly checkout z-shell/zd in reusable workflow#65ss-o wants to merge 1 commit into
ss-o wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the reusable native test workflow to be safer/more deterministic by pinning actions/checkout and ensuring the workflow checks out the intended repository when invoked via workflow_call.
Changes:
- Pinned
actions/checkoutto a full commit SHA intest-native.yml. - Updated checkout step to explicitly clone
z-shell/zd(instead of implicitly using the caller repo inworkflow_callscenarios).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+47
to
+49
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4 | ||
| with: | ||
| repository: z-shell/zd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/checkoutto a full commit SHA in the reusabletest-native.ymlworkflowz-shell/zd(instead of usinggithub.shawhich is not cloneable as a branch ref when called from external repos viaworkflow_call)Test plan
z-shell/ziwithworkflow_callwithout checkout errorstest-native.ymlpasses end-to-end