Skip to content

Refactor installer scripts and update CI workflows#159

Closed
ss-o wants to merge 8 commits into
mainfrom
next
Closed

Refactor installer scripts and update CI workflows#159
ss-o wants to merge 8 commits into
mainfrom
next

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 16, 2026

This pull request focuses on modernizing and improving the project's CI/CD workflows, updating dependency references, and cleaning up project-specific configuration and spelling files. The changes enhance automation reliability, improve test coverage, and ensure consistency across different environments. Additionally, several legacy or unused workflow files have been removed to streamline the repository.

CI/CD Workflow Improvements

  • Updated all GitHub Actions workflow files to use the latest versions of third-party actions (such as actions/checkout and ludeeus/action-shellcheck), added timeouts, permissions, and concurrency controls, and expanded test coverage to include more directories and test scripts. This ensures more robust and secure automation across Linux, macOS, and Windows environments. [1] [2] [3] [4] [5] [6] [7] [8] [9]

  • Improved workflow logic for deployment and synchronization jobs by adding repository checks, better commit message handling, and more precise file path triggers. [1] [2] [3] [4]

Test Coverage Enhancements

  • Added explicit steps to run new or updated test scripts (such as tests/installers.sh) and included smoke tests to verify installation artifacts, increasing confidence in installer reliability across platforms. [1] [2] [3]

Repository Cleanup

  • Removed obsolete or redundant workflow files, including those for rebasing, label synchronization, stale issue management, and Wrangler deployments, simplifying the CI/CD configuration. [1] [2] [3] [4]

Configuration and Spelling Updates

  • Cleaned up project-specific spelling and username files by removing unused or outdated entries, and updated .editorconfig to remove excessive comments and clarify formatting rules. [1] [2] [3] [4] [5]

ss-o and others added 8 commits May 15, 2026 23:58
Remove obsolete cspell word lists, editorconfig, vscode settings,
and retired workflows (rebase, stale, sync-labels, wrangler).
Drop legacy installer scripts i.sh and install_alpha.sh.
- Bump actions/checkout to v6.0.2 and shellcheck to 2.0.0
- Add lib/zsh/** and tests/** to push/PR path triggers
- Add permissions: contents: read and timeout-minutes: 10
- Use github.ref in concurrency group
- Replace ~/.zi hard-coded paths with XDG_DATA_HOME equivalents
- Add unit-fixture step calling tests/installers.sh
- Remove wrangler deploy job; update trunk linter config
sync-init.sh verifies (and optionally replaces) the local lib/zsh/init.zsh
against the canonical GitHub raw main copy. Supports --write, --local,
--remote, --checksum-url and --no-checksum flags.

tests/installers.sh provides a POSIX sh test suite covering:
- script syntax validation (sh -n / zsh -n)
- checksum integrity checks
- loader install with XDG path and branch-override assertions
- standalone zpmod delegation test
- sync-init fixture round-trip test
install.sh:
- Add set -eu; use WORKDIR=$(mktemp -d) with safe trap cleanup
- Replace ~/.zi with XDG_DATA_HOME-aware path
- Fix sed command for ZI[STREAM] substitution
- Correct cd fallback from return to exit 1
- Guard branch pull with BOPT; add exit 1 on failed clone
- Fix .zshrc loader snippet variable quoting

install_zpmod.sh:
- Add set -eu, file header and WORKDIR trap
- Add pure-POSIX _zi_ver_ge() replacing expr string comparison
- Honour XDG_DATA_HOME for ZI_HOME default
- Replace exit 255 with exit 1 throughout

lib/zsh/init.zsh:
- Update default branch to use ZI[STREAM] parameter
- Align loader paths with XDG layout
- Exclude AI agent instruction files from git tracking
  (AGENTS.md, CLAUDE.md, GEMINI.md, .github/copilot-instructions.md)
- Add .geminiignore
- Regenerate lib/checksum.txt to reflect updated scripts
- Document sync-init.sh usage in docs/README.md
- Remove deprecated git.io short URLs from README
* ci(check-linux): add init.zsh sync-drift detection step

* fix(install.sh): verify zi.zsh exists after clone, not just directory

* ci: add concurrency to checksum.yml; add smoke-test to win-install.yml

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* feat: add color.zsh from molovo/color (MIT)

* feat: add revolver from molovo/revolver (MIT)

* chore: rename repo references from zi-src to src

Update all internal references to reflect the repository rename:
- .trunk/trunk.yaml repo name
- workflow repository guards (checksum, rclone-action, deploy-gh-pages)
- win-install safe.directory path
- docs/README.md VSCode and jsDelivr URLs

* ci: add org project tracker scripts (label sync + workflow rollout)

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>

* fix: address review feedback for revolver process check and installer URLs

Agent-Logs-Url: https://github.com/z-shell/src/sessions/3295a818-69b9-4b0d-99f8-bf27b90e3b7c

Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>

* fix: validate revolver pid before liveness check

Agent-Logs-Url: https://github.com/z-shell/src/sessions/3295a818-69b9-4b0d-99f8-bf27b90e3b7c

Co-authored-by: ss-o <59910950+ss-o@users.noreply.github.com>

---------

Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>
Signed-off-by: Sall <59910950+ss-o@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 16, 2026

Deploying src with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4c6da9a
Status: ✅  Deploy successful!
Preview URL: https://a6c58409.zi-src.pages.dev
Branch Preview URL: https://next.zi-src.pages.dev

View logs

@ss-o
Copy link
Copy Markdown
Member Author

ss-o commented May 16, 2026

Closing as this PR is stale and has been superseded by the refactoring merged in #160.

@ss-o ss-o closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants