Skip to content

Remove deprecated files and update workflows with new scripts#157

Closed
ss-o wants to merge 15 commits into
mainfrom
ci/loader-sync-check
Closed

Remove deprecated files and update workflows with new scripts#157
ss-o wants to merge 15 commits into
mainfrom
ci/loader-sync-check

Conversation

@ss-o
Copy link
Copy Markdown
Member

@ss-o ss-o commented May 16, 2026

This pull request makes significant updates and cleanups to the project's GitHub Actions workflows and configuration files. The main focus is on improving CI reliability, updating dependencies, removing unused workflows, and enhancing test coverage. Additionally, several configuration and spelling files have been updated or cleaned up.

GitHub Actions workflow improvements and cleanup:

  • Updated CI workflows (check-linux.yml, check-macos.yml, win-install.yml, rclone-action.yml, deploy-gh-pages.yml, checksum.yml) to:

    • Add new test coverage for lib/zsh/** and tests/** directories.
    • Use the latest versions of actions/checkout and other third-party actions.
    • Add explicit permissions and concurrency controls.
    • Improve cleanup logic to use ${XDG_DATA_HOME:-$HOME/.local/share}/zi instead of hardcoded paths.
    • Add timeout limits and additional test steps, including smoke tests for installation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]
  • Removed obsolete or unused workflows:

    • Deleted stale issue/PR cleanup (stale-action.yml), label sync (sync-labels.yml), rebase automation (rebase-action.yml), and wrangler deployment (wrangler.yml) workflows to reduce maintenance burden and CI noise. [1] [2] [3] [4]

Configuration and spelling dictionary updates:

  • Cleaned up and updated spelling/project word lists by removing unused or obsolete entries in .cspell/project-words.txt, .github/.cspell/project-words.txt, .github/.cspell/project-ignored.txt, and .github/.cspell/project-usernames.txt. [1] [2] [3] [4]

  • Simplified and cleaned up .editorconfig by removing extensive comments and unused sections.

These changes collectively modernize the CI/CD pipeline, improve test reliability, and keep the repository configuration files tidy and relevant.

ss-o and others added 9 commits May 15, 2026 23:58
Remove obsolete cspell word lists, editorconfig, vscode settings,
and retired workflows (rebase, stale, sync-labels, wrangler).
Drop legacy installer scripts i.sh and install_alpha.sh.
- Bump actions/checkout to v6.0.2 and shellcheck to 2.0.0
- Add lib/zsh/** and tests/** to push/PR path triggers
- Add permissions: contents: read and timeout-minutes: 10
- Use github.ref in concurrency group
- Replace ~/.zi hard-coded paths with XDG_DATA_HOME equivalents
- Add unit-fixture step calling tests/installers.sh
- Remove wrangler deploy job; update trunk linter config
sync-init.sh verifies (and optionally replaces) the local lib/zsh/init.zsh
against the canonical GitHub raw main copy. Supports --write, --local,
--remote, --checksum-url and --no-checksum flags.

tests/installers.sh provides a POSIX sh test suite covering:
- script syntax validation (sh -n / zsh -n)
- checksum integrity checks
- loader install with XDG path and branch-override assertions
- standalone zpmod delegation test
- sync-init fixture round-trip test
install.sh:
- Add set -eu; use WORKDIR=$(mktemp -d) with safe trap cleanup
- Replace ~/.zi with XDG_DATA_HOME-aware path
- Fix sed command for ZI[STREAM] substitution
- Correct cd fallback from return to exit 1
- Guard branch pull with BOPT; add exit 1 on failed clone
- Fix .zshrc loader snippet variable quoting

install_zpmod.sh:
- Add set -eu, file header and WORKDIR trap
- Add pure-POSIX _zi_ver_ge() replacing expr string comparison
- Honour XDG_DATA_HOME for ZI_HOME default
- Replace exit 255 with exit 1 throughout

lib/zsh/init.zsh:
- Update default branch to use ZI[STREAM] parameter
- Align loader paths with XDG layout
- Exclude AI agent instruction files from git tracking
  (AGENTS.md, CLAUDE.md, GEMINI.md, .github/copilot-instructions.md)
- Add .geminiignore
- Regenerate lib/checksum.txt to reflect updated scripts
- Document sync-init.sh usage in docs/README.md
- Remove deprecated git.io short URLs from README
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 16, 2026

Deploying zi-src with  Cloudflare Pages  Cloudflare Pages

Latest commit: 328ebd1
Status: ✅  Deploy successful!
Preview URL: https://a7e5b113.zi-src.pages.dev
Branch Preview URL: https://ci-loader-sync-check.zi-src.pages.dev

View logs

ss-o and others added 2 commits May 16, 2026 08:20
Update all internal references to reflect the repository rename:
- .trunk/trunk.yaml repo name
- workflow repository guards (checksum, rclone-action, deploy-gh-pages)
- win-install safe.directory path
- docs/README.md VSCode and jsDelivr URLs
@ss-o ss-o marked this pull request as ready for review May 16, 2026 08:53
Copilot AI review requested due to automatic review settings May 16, 2026 08:53
@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 16, 2026

Deploying src with  Cloudflare Pages  Cloudflare Pages

Latest commit: 076599f
Status: ✅  Deploy successful!
Preview URL: https://b8da2fcd.zi-src.pages.dev
Branch Preview URL: https://ci-loader-sync-check.zi-src.pages.dev

View logs

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

ss-o and others added 3 commits May 16, 2026 15:59
* fix(ci): fix rclone docker build and update checksums

- Update rclone and commit actions to v1.0.9 in z-shell/.github to fix pinned Alpine package failures
- Update lib/checksum.txt to match current lib/sh/install.sh

* Checksum d23c74a

---------

Co-authored-by: ss-o <ss-o@users.noreply.github.com>
Co-authored-by: digital-teams[bot] <actions@zshell.dev>
mkdir without -p fails on clean runners where ~/.local/share does not
exist. Using -p ensures all parent directories are created.
@ss-o
Copy link
Copy Markdown
Member Author

ss-o commented May 16, 2026

Closing as this PR is stale and has been superseded by the refactoring merged in #160.

@ss-o ss-o closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants