Update crawldata.py#1
Open
saraskardelly wants to merge 1 commit intosaraskardelly-patch-1from
Open
Conversation
Hi, I have now added Bloomberg and Washington Post. I will send you a detailed message on Discord. Thank you very much.
ywcb00
reviewed
May 11, 2023
| 'article-links': { | ||
| 'overview-urls': ['/markets', '/technology', '/politics', '/world'], | ||
| 'find-tags': [ # Hierarchy | ||
| {'type': 'include', 'name': 'header', 'attrs': {'class': 'story-package-module_ _stories'}}, |
Owner
There was a problem hiding this comment.
This configuration seems not to find any article links since there is no container named 'header' in the html page of bloomberg.com. You might have forgotten to change the container name in this line (copy-paste mistake?).
| 'article-links': { | ||
| 'overview-urls': ['/politics', '/world', '/business', '/technology', '/sports'], | ||
| 'find-tags': [ # Hierarchy | ||
| {'type': 'include', 'name': 'header', 'attrs': {'class': 'headline'}}, |
| 'overview-urls': ['/markets', '/technology', '/politics', '/world'], | ||
| 'find-tags': [ # Hierarchy | ||
| {'type': 'include', 'name': 'header', 'attrs': {'class': 'story-package-module_ _stories'}}, | ||
| {'type': 'include', 'name': 'a', 'attrs': {'class': 'story-package-module_ _story_ _headline-link'}} |
Owner
There was a problem hiding this comment.
The crawler cannot handle multiple class definitions separated with whitespaces. Either try to pass an array (untested) or reduce these specifications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have now added Bloomberg and Washington Post. I will send you a detailed message on Discord. Thank you very much.