Initial changes and adaptations for embedded use #7
Initial changes and adaptations for embedded use #7emaayan wants to merge 2 commits intoyparitcher:masterfrom
Conversation
emaayan
commented
Feb 11, 2023
- added library.json as manifest
- added small type casting due variable size being truncated in arduino
- replaced some ' chars which won't display well on LCD
- replaced types in zmanim that linter didn't like
There was a problem hiding this comment.
I would prefer not to have arduino specific files in the repo.
The library is designed with a 32 bit int (most modern platforms). to adapt it to a 16 bit int would need to change many of the signatures to guarantee correctness, not just the few you changed
| ,"-I windows" | ||
| ,"-D _WIN32" |
There was a problem hiding this comment.
There should be no need to define windows.
There was a problem hiding this comment.
this is one of the hardest things i had here, i wouldn't call it defining windows as more like for platorms who don't have stpncpy , if i won't include the stpncpy.h and the source the file the avr-gcc will fail cause it won't find them, i don't know of any other way to handle this.
| const char* hchar[]={ "׆", "א", "ב", "ג", "ד", "ה", "ו", "ז", "ח", "ט", "י", "כ", "ל", "מ", "נ", "ס", "ע", "פ", "צ", "ק", "ר", "ש", "ת", "״", "׳"}; | ||
| const char* hmonth[]={ "אדר א׳", "ניסן", "אייר", "סיון", "תמוז", "אב", "אלול", "תשרי", "חשון", "כסלו", "טבת", "שבט", "אדר", "אדר ב׳"}; | ||
| const char* hchar[]={ "׆", "א", "ב", "ג", "ד", "ה", "ו", "ז", "ח", "ט", "י", "כ", "ל", "מ", "נ", "ס", "ע", "פ", "צ", "ק", "ר", "ש", "ת", "\"", "'"}; | ||
| const char* hmonth[]={ "אדר א'", "ניסן", "אייר", "סיון", "תמוז", "אב", "אלול", "תשרי", "חשון", "כסלו", "טבת", "שבט", "אדר", "אדר ב'"}; |
There was a problem hiding this comment.
I find the geresh & gershaim better,
There was a problem hiding this comment.
I would prefer not to have arduino specific files in the repo. The library is designed with a 32 bit int (most modern platforms). to adapt it to a 16 bit int would need to change many of the signatures to guarantee correctness, not just the few you changed
so far it has worked splendidly with what i have right now.
currently arduino doesn't have memory to use the zmanim.c, so i plan to port it to esp32 which i believe is a 32bit library.
There was a problem hiding this comment.
I find the geresh & gershaim better,
unfortuently those don't display well, in LCD, the alternative the way i see it is to have a completely different set of strings just for embedded, but then you'd have to maintain 2 sets.
if you mean library.json, it's not exactly arduino specific, it's manifest for library depdencies, much like rockspec. |