Repository navigation
Fix Swift Testing error matcher failing on Linux - #1657
Merged
Merged
Conversation
Cast the thrown error to SpecParsingError instead of coercing it to CustomStringConvertible, which goes through NSError bridging and yields a different description on Linux. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
yonaskolb
added a commit
that referenced
this pull request
Oct 13, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvalidConfigsMappingFormatTestsfails on Linux CI now that the newer ubuntu runner image runs Swift Testing tests (example: https://github.com/yonaskolb/XcodeGen/actions/runs/38357691066).The error matcher coerced the thrown
any Errorwithas any CustomStringConvertible. That coercion goes throughNSErrorbridging, which on Darwin forwards to the Swift error'sdescriptionbut on Linux produces the genericNSErrordescription, so the comparison fails even though the correctSpecParsingErroris thrown.The matcher now casts to
SpecParsingErrorand compares itsdescription. This was the only Swift Testing test using the pattern.🤖 Generated with Claude Code