Skip to content

Remove BC dev dependency input#801

Merged
samdark merged 1 commit into
masterfrom
remove-bc-install-development-dependencies
May 31, 2026
Merged

Remove BC dev dependency input#801
samdark merged 1 commit into
masterfrom
remove-bc-install-development-dependencies

Conversation

@samdark
Copy link
Copy Markdown
Member

@samdark samdark commented May 31, 2026

Summary

  • remove the install-development-dependencies input from the reusable BC workflow call
  • run the BC workflow on PHP 8.3 so Roave's XML baseline support is available
  • add Roave BC baseline ignores for dev-only Yii Debug classes and existing date/time message default changes

Related

Verification

  • vendor/bin/roave-backward-compatibility-check passed locally with: No backwards-incompatible changes detected

Copilot AI review requested due to automatic review settings May 31, 2026 13:04
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s backwards-compatibility (BC) checking setup to align with the upstream reusable workflow change and to prevent known, non-actionable BC-check findings from failing CI.

Changes:

  • Removes the install-development-dependencies input from the reusable yiisoft/actions BC workflow call.
  • Adds a Roave BC baseline config to ignore:
    • skipped reflections for dev-only yiisoft/yii-debug classes
    • known default-parameter-message changes in date/time rule handlers

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.roave-backward-compatibility-check.xml Adds baseline ignore patterns for expected/skipped BC-check output.
.github/workflows/bc.yml Updates the reusable workflow call by removing the deprecated input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samdark samdark force-pushed the remove-bc-install-development-dependencies branch from 8026f76 to f1ab006 Compare May 31, 2026 13:12
@samdark samdark merged commit 18f2674 into master May 31, 2026
35 checks passed
@samdark samdark deleted the remove-bc-install-development-dependencies branch May 31, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants