Add note about cookie protection - #126
Open
vjik wants to merge 5 commits into
Open
Conversation
vjik
commented
Aug 16, 2026
vjik
commented
Member
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
| Fix #125 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=========================================
Coverage 99.65% 99.65%
Complexity 110 110
=========================================
Files 15 15
Lines 290 290
=========================================
Hits 289 289
Misses 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
samdark
requested changes
Aug 30, 2026
| validate it and login the user automatically. | ||
|
|
||
| > [!note] | ||
| > The auto-login cookie value isn't protected against tampering by this package. This isn't only about |
Member
There was a problem hiding this comment.
Isn't it already mentioned in "Preventing the substitution of cookies" which mentions order which is critical for it to work?
| * | ||
| * The auto-login cookie value isn't protected against tampering by this package. This isn't only about | ||
| * the end user editing their own cookie — anyone who steals the cookie value can modify it too, e.g. to | ||
| * remove its expiration. Use {@see CookieMiddleware} to sign or encrypt it if you want to prevent that. |
Member
There was a problem hiding this comment.
I think it's better to refer to README since order of middlware is critical for it to work proeprly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.