-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add ENUM column
#465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Add ENUM column
#465
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
703abc8
start
vjik b3fa56d
improve
vjik d63d7a7
Merge remote-tracking branch 'origin/master' into enum-col
vjik c006cc8
improve
vjik 454bb59
Apply PHP CS Fixer and Rector changes (CI)
vjik 7e471df
fix
vjik ef091cb
Merge remote-tracking branch 'origin/enum-col' into enum-col
vjik 269321d
improve
vjik 72ce6ad
improve
vjik c26c329
Apply PHP CS Fixer and Rector changes (CI)
vjik f28fd16
improve
vjik 8e0304c
improve
vjik 7389aa9
test
vjik b913801
Merge branch 'master' into enum-col
vjik 8d0630c
more tests
vjik 89af030
changelog
vjik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Yiisoft\Db\Pgsql\Tests\Column; | ||
|
|
||
| use PHPUnit\Framework\Attributes\TestWith; | ||
| use Yiisoft\Db\Pgsql\Tests\Support\IntegrationTestTrait; | ||
| use Yiisoft\Db\Schema\Column\EnumColumn; | ||
| use Yiisoft\Db\Tests\Common\CommonEnumColumnTest; | ||
|
|
||
| final class EnumColumnTest extends CommonEnumColumnTest | ||
| { | ||
| use IntegrationTestTrait; | ||
|
|
||
| #[TestWith(['INTEGER CHECK (status IN (1, 2, 3))'])] | ||
| #[TestWith(["TEXT CHECK (status != 'abc')"])] | ||
| #[TestWith(["TEXT CHECK (status IN ('a', 'b') OR status = 'x')"])] | ||
| #[TestWith(["TEXT CHECK (status IN ('a', 'b') OR status IN ('x', 'y'))"])] | ||
| public function testNonEnumCheck(string $columnDefinition): void | ||
| { | ||
| $this->dropTable('test_enum_table'); | ||
| $this->executeStatements( | ||
| <<<SQL | ||
| CREATE TABLE test_enum_table ( | ||
| id INTEGER, | ||
| status $columnDefinition | ||
| ) | ||
| SQL, | ||
| ); | ||
|
|
||
| $db = $this->getSharedConnection(); | ||
| $column = $db->getTableSchema('test_enum_table')->getColumn('status'); | ||
|
|
||
| $this->assertNotInstanceOf(EnumColumn::class, $column); | ||
|
|
||
| $this->dropTable('test_enum_table'); | ||
| } | ||
|
|
||
| protected function createDatabaseObjectsStatements(): array | ||
| { | ||
| return [ | ||
| <<<SQL | ||
| CREATE TYPE enum_status AS ENUM ('active', 'unactive', 'pending') | ||
vjik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| SQL, | ||
| <<<SQL | ||
| CREATE TABLE tbl_enum ( | ||
| id INTEGER, | ||
| status enum_status | ||
| ) | ||
| SQL, | ||
| ]; | ||
| } | ||
|
|
||
| protected function dropDatabaseObjectsStatements(): array | ||
| { | ||
| return [ | ||
| 'DROP TABLE IF EXISTS tbl_enum', | ||
| 'DROP TYPE IF EXISTS enum_status', | ||
| ]; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.