Skip to content

Add Hermes Agent discovery support#1

Open
kriptoburak wants to merge 2 commits into
yfge:mainfrom
kriptoburak:codex/hermes-agent-discovery
Open

Add Hermes Agent discovery support#1
kriptoburak wants to merge 2 commits into
yfge:mainfrom
kriptoburak:codex/hermes-agent-discovery

Conversation

@kriptoburak

Copy link
Copy Markdown

Summary

  • Expands default GitHub discovery to include Hermes Agent and Hermes plugin repositories.
  • Detects Hermes Agent plugins during repository inspection.
  • Adds social capability and action-gate environment key recognition.

Checks

  • License reviewed: MIT.
  • Duplicate check: no open or closed Hermes Tweet, Xquik, or Hermes Agent PR found in this repo.
  • Link check: Hermes Tweet repo, README, and .claude-plugin manifest return 200.
  • Validation: uv run --python 3.12 pytest backend/tests/test_repository_inspection_service.py passed with project requirements minus unavailable optional mcp[cli].

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6ee4a8ded5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +148 to +150
"hermes agent" in haystack
or "hermes-agent" in haystack
or "hermes plugin" in haystack

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve manifest-only Hermes plugin detection

For Hermes plugins whose only repository marker is the root .claude-plugin manifest, this phrase-only check never matches: source_files is built after filtering root files through KEY_FILES, which does not include .claude-plugin, so the manifest shown in the new test is dropped before detection. Those repos fall through to another type (often claude_skill) unless their README/topics also contain the exact Hermes phrases, so include/preserve the manifest in the inspection path and use it for classification.

Useful? React with 👍 / 👎.

@kriptoburak

Copy link
Copy Markdown
Author

Addressed the manifest-only detection finding in HEAD. The root .claude-plugin marker is now retained in source_files, and manifest-only plugin repos can still be classified as Hermes plugin entries.

Validation passed:

  • Python 3.11 temp venv install with pip install -r backend/requirements.txt -r backend/requirements-dev.txt
  • python -m pytest backend/tests/test_repository_inspection_service.py -q
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant