feat: add actix support for yew-link#4113
feat: add actix support for yew-link#4113stifskere wants to merge 4 commits intoyewstack:yew-linkfrom
Conversation
|
The workflow error is a network request error. I assume the workflow could be re-run as I don't see any reason why would that specific workflow fail. |
|
I restarted the workflow |
Madoshakalaka
left a comment
There was a problem hiding this comment.
I merged master into the yew-link branch. Can you merge from yew-link first and then address the reviews?
It's quite late in here, I will address it tomorrow when I have the chance. |
|
I didn't realize you meant the |
Madoshakalaka
left a comment
There was a problem hiding this comment.
Can you also come up with an SSR actix-web example in examples and extend tools/ssr-e2e to test it? Possibly will also involve tweaking the end of .github/workflows/main-checks.yml. Also don't forget to include it in the table in examples/README.md
It's quite important because
- I don't personally use actix-web so I have less confidence this works perfectly.
- It will be our first actix example (we had warp and axum examples only)
- this will lend us more confidence in future refactoring.
| use yew_link::{Resolver, linked_state_handler}; | ||
| use yew_link::Resolver; | ||
| use axum::linked_state_handler; |
There was a problem hiding this comment.
earlier miscommunication
can we have the old one back?
otherwise it should be use yew_link::axum::linked_state_handler;
Description
Adds
actix_websupport for theyew_linkcrate introduced in #4027.Checklist