Skip to content

feat: add actix support for yew-link#4113

Open
stifskere wants to merge 4 commits intoyewstack:yew-linkfrom
stifskere:yew-link
Open

feat: add actix support for yew-link#4113
stifskere wants to merge 4 commits intoyewstack:yew-linkfrom
stifskere:yew-link

Conversation

@stifskere
Copy link
Copy Markdown

Description

Adds actix_web support for the yew_link crate introduced in #4027.

Checklist

  • I have reviewed my own code
  • I have added tests

@stifskere
Copy link
Copy Markdown
Author

The workflow error is a network request error.

I assume the workflow could be re-run as I don't see any reason why would that specific workflow fail.

@Madoshakalaka
Copy link
Copy Markdown
Member

I restarted the workflow

Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged master into the yew-link branch. Can you merge from yew-link first and then address the reviews?

@stifskere
Copy link
Copy Markdown
Author

I merged master into the yew-link branch. Can you merge from yew-link first and then address the reviews?

It's quite late in here, I will address it tomorrow when I have the chance.

@stifskere stifskere requested a review from Madoshakalaka April 4, 2026 22:19
@stifskere
Copy link
Copy Markdown
Author

I didn't realize you meant the ,, I thought you meant the use statements xD.

Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also come up with an SSR actix-web example in examples and extend tools/ssr-e2e to test it? Possibly will also involve tweaking the end of .github/workflows/main-checks.yml. Also don't forget to include it in the table in examples/README.md

It's quite important because

  1. I don't personally use actix-web so I have less confidence this works perfectly.
  2. It will be our first actix example (we had warp and axum examples only)
  3. this will lend us more confidence in future refactoring.

Comment on lines -203 to +204
use yew_link::{Resolver, linked_state_handler};
use yew_link::Resolver;
use axum::linked_state_handler;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

earlier miscommunication
can we have the old one back?

otherwise it should be use yew_link::axum::linked_state_handler;

@Madoshakalaka Madoshakalaka added the A-yew-link Area: The yew-link crate label Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew-link Area: The yew-link crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants