perf: cache empty VList Rc in VNode::default to avoid repeated heap allocation#4089
Draft
Madoshakalaka wants to merge 1 commit intomasterfrom
Draft
perf: cache empty VList Rc in VNode::default to avoid repeated heap allocation#4089Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
…llocation VNode::default() is called on every mem::take() during reconciliation. Previously each call heap-allocated a new Rc<VList>. Use a thread_local to cache a single Rc<VList> and reuse it via Rc::clone (refcount bump only).
|
Visit the preview URL for this PR (updated for commit 3aad31b): https://yew-rs-api--pr4089-perf-vnode-default-a-byvsziqq.web.app (expires Sun, 05 Apr 2026 14:40:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.