-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Ensure html_nested returns the inner type #3493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
5493421 to
169f6bc
Compare
|
Visit the preview URL for this PR (updated for commit ba98704): https://yew-rs-api--pr3493-html-nested-types-6gu7o8xf.web.app (expires Sat, 04 Nov 2023 14:53:46 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
|
Compile failures will be resolved by #3453 |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
169f6bc to
95a4b26
Compare
95a4b26 to
688b753
Compare
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
|
I feel this is an expected behaviour. See: https://docs.rs/yew/latest/yew/macro.html_nested.html
The documentation suggested that only Returning other types would encourage inspection of VNode, which I am not in favour of. |
Description
At some point in time, html_nested broke and started returning VNode instead of inner types. This PR fixes that
Checklist