Conversation
# Conflicts: # .github/workflows/main-checks.yml # examples/agents/Cargo.toml # examples/boids/Cargo.toml # examples/contexts/Cargo.toml # examples/counter/Cargo.toml # examples/dyn_create_destroy_apps/Cargo.toml # examples/file_upload/Cargo.toml # examples/function_memory_game/Cargo.toml # examples/function_router/Cargo.toml # examples/function_router/index.html # examples/function_todomvc/Cargo.toml # examples/futures/Cargo.toml # examples/game_of_life/Cargo.toml # examples/inner_html/Cargo.toml # examples/js_callback/Cargo.toml # examples/keyed_list/Cargo.toml # examples/mount_point/Cargo.toml # examples/nested_list/Cargo.toml # examples/node_refs/Cargo.toml # examples/password_strength/Cargo.toml # examples/portals/Cargo.toml # examples/portals/src/main.rs # examples/router/Cargo.toml # examples/suspense/Cargo.toml # examples/timer/Cargo.toml # examples/todomvc/Cargo.toml # examples/two_apps/Cargo.toml # examples/web_worker_fib/Cargo.toml # examples/webgl/Cargo.toml # packages/yew-router/Cargo.toml # packages/yew/Cargo.toml # packages/yew/Makefile.toml # packages/yew/src/app_handle.rs # packages/yew/src/dom_bundle/bcomp.rs # packages/yew/src/dom_bundle/bportal.rs # packages/yew/src/dom_bundle/bsuspense.rs # packages/yew/src/dom_bundle/btag/listeners.rs # packages/yew/src/dom_bundle/btag/mod.rs # packages/yew/src/dom_bundle/btext.rs # packages/yew/src/dom_bundle/mod.rs # packages/yew/src/dom_bundle/traits.rs # packages/yew/src/dom_bundle/utils.rs # packages/yew/src/html/component/lifecycle.rs # packages/yew/src/html/component/mod.rs # packages/yew/src/html/component/scope.rs # packages/yew/src/html/mod.rs # packages/yew/src/lib.rs # packages/yew/src/renderer.rs # packages/yew/src/scheduler.rs # packages/yew/src/server_renderer.rs # packages/yew/src/suspense/component.rs # packages/yew/src/suspense/mod.rs # packages/yew/src/tests/layout_tests.rs # packages/yew/src/virtual_dom/vcomp.rs # packages/yew/src/virtual_dom/vlist.rs # packages/yew/src/virtual_dom/vsuspense.rs # packages/yew/src/virtual_dom/vtag.rs # packages/yew/src/virtual_dom/vtext.rs # tools/website-test/Cargo.toml # website/docs/advanced-topics/portals.mdx # website/docs/getting-started/build-a-sample-app.mdx # website/docs/tutorial/index.mdx
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit a339020): https://yew-rs--pr2552-hydration-3-lgz3svc0.web.app (expires Sat, 09 Apr 2022 12:41:20 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
|
WorldSEnder
requested changes
Apr 1, 2022
Member
WorldSEnder
left a comment
WorldSEnder
left a comment
There was a problem hiding this comment.
Found the time to review it in more detail.
WorldSEnder
reviewed
Apr 2, 2022
WorldSEnder
approved these changes
Apr 2, 2022
Member
WorldSEnder
left a comment
WorldSEnder
left a comment
There was a problem hiding this comment.
Looks reasonably complete to approve this. As always, thanks for all the effort ❤️
ranile
approved these changes
Apr 2, 2022
Comment on lines
184
to
+185
| Example: [simple\_ssr](https://github.com/yewstack/yew/tree/master/examples/simple_ssr) | ||
| Example: [ssr\_router](https://github.com/yewstack/yew/tree/master/examples/ssr_router) |
Member
There was a problem hiding this comment.
I would bring these in line with how it's placed in other places:
## Further reading
- The [`simple_ssr`](https://github.com/yewstack/yew/tree/master/examples/simple_ssr) example
- The [`ssr_router`](https://github.com/yewstack/yew/tree/master/examples/ssr_router) exampleIt's not blocking and can be done in a future PR
|
|
||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] | ||
| tokio = { version = "1.15.0", features = ["full"] } | ||
| warp = "0.3" |
Member
There was a problem hiding this comment.
I haven't tried it. I will give it a shot later. We can merge it in as-is and I will hopefully update it soon. I'm probably going to need some help from the #axum in tokio's server though...
Member
|
@futursolo feel free to merge it if there's no more changes you want to make here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2453 (Supersedes it).
Closes #41.
This pull request introduces
Renderer::hydrateand SSR Hydration.Checklist
cargo make pr-flow