Introduce additional information in SSR artifact to facilitate Hydration#2540
Merged
futursolo merged 9 commits intoyewstack:masterfrom Mar 25, 2022
Merged
Introduce additional information in SSR artifact to facilitate Hydration#2540futursolo merged 9 commits intoyewstack:masterfrom
futursolo merged 9 commits intoyewstack:masterfrom
Conversation
# Conflicts: # .github/workflows/main-checks.yml # examples/agents/Cargo.toml # examples/boids/Cargo.toml # examples/contexts/Cargo.toml # examples/counter/Cargo.toml # examples/dyn_create_destroy_apps/Cargo.toml # examples/file_upload/Cargo.toml # examples/function_memory_game/Cargo.toml # examples/function_router/Cargo.toml # examples/function_router/index.html # examples/function_todomvc/Cargo.toml # examples/futures/Cargo.toml # examples/game_of_life/Cargo.toml # examples/inner_html/Cargo.toml # examples/js_callback/Cargo.toml # examples/keyed_list/Cargo.toml # examples/mount_point/Cargo.toml # examples/nested_list/Cargo.toml # examples/node_refs/Cargo.toml # examples/password_strength/Cargo.toml # examples/portals/Cargo.toml # examples/router/Cargo.toml # examples/suspense/Cargo.toml # examples/timer/Cargo.toml # examples/todomvc/Cargo.toml # examples/two_apps/Cargo.toml # examples/web_worker_fib/Cargo.toml # examples/webgl/Cargo.toml # packages/yew-router/Cargo.toml # packages/yew/Cargo.toml # packages/yew/Makefile.toml # packages/yew/src/app_handle.rs # packages/yew/src/dom_bundle/bcomp.rs # packages/yew/src/dom_bundle/mod.rs # packages/yew/src/dom_bundle/traits.rs # packages/yew/src/html/component/lifecycle.rs # packages/yew/src/html/component/mod.rs # packages/yew/src/html/component/scope.rs # packages/yew/src/html/mod.rs # packages/yew/src/lib.rs # packages/yew/src/renderer.rs # packages/yew/src/scheduler.rs # packages/yew/src/suspense/component.rs # packages/yew/src/suspense/mod.rs # packages/yew/src/virtual_dom/vcomp.rs # tools/website-test/Cargo.toml # website/docs/getting-started/build-a-sample-app.mdx # website/docs/tutorial/index.mdx
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Visit the preview URL for this PR (updated for commit e81f07c): https://yew-rs-api--pr2540-hydration-2-1bhtymj2.web.app (expires Fri, 01 Apr 2022 11:02:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
|
ranile
previously approved these changes
Mar 22, 2022
Member
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Looks good to me. The one comment I left isn't blocking, feel free to address it here or merge it and take care of it in the future, if you want.
futursolo
dismissed stale reviews from ranile and github-actions[bot]
via
b52d63b
WorldSEnder
requested changes
Mar 24, 2022
Member
WorldSEnder
left a comment
WorldSEnder
left a comment
There was a problem hiding this comment.
Looks mostly good to me, just slight nitpicks and one question.
WorldSEnder
approved these changes
Mar 25, 2022
Member
WorldSEnder
left a comment
WorldSEnder
left a comment
There was a problem hiding this comment.
lgtm, everything addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Originally part of #2453.
This pull request introduces assistive nodes on server-side rendered artifacts to assist hydration.
Checklist
cargo make pr-flow