Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 47121fa): https://yew-rs-api--pr2495-fix-wasm-bench-3caj2a1i.web.app (expires Sun, 13 Mar 2022 06:53:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
3 tasks
voidpumpkin
approved these changes
Mar 7, 2022
Member
voidpumpkin
left a comment
voidpumpkin
left a comment
There was a problem hiding this comment.
I dont really have an opinion regarding this. I see we had some benches for diffing but idk if we ever looked at/used those.
ranile
approved these changes
Mar 7, 2022
Member
|
I agree that we should pull it out. Benchmarks can be added in afterwards where needed |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After #2330, benchmark related code does not compile and trips clippy.
I think @voidpumpkin mentioned that this piece of code didn't work as expected before #2330 anyways.
I feel it's easier to solve this by removing the old benchmark as now Yew has a different way to benchmark.
Checklist
cargo make pr-flow(No, Clippy crash (version 1.59 on macOS) rust-lang/rust-clippy#8470)