Skip to content

Add YDB_PDISK_SIZE environment variable with KB/MB/GB/TB suffix support #28921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add YDB_PDISK_SIZE environment variable with KB/MB/GB/TB suffix support #28921

wants to merge 8 commits into from
+9 −1

Conversation

Copy link
Contributor

Copilot AI commented Nov 14, 2025 •
edited
Loading

Changelog entry

Added documentation for YDB_PDISK_SIZE environment variable in Docker configuration reference and extended implementation to support KB, MB, GB, and TB suffixes.

Changelog category

  • Improvement

Description for reviewers

The YDB_PDISK_SIZE environment variable was already implemented in the codebase but missing from the Docker configuration documentation pages. Additionally, the implementation only supported GB suffix, which has now been extended to support KB, MB, GB, and TB suffixes.

Changes:

  • Added YDB_PDISK_SIZE entry to English documentation (ydb/docs/en/core/reference/docker/configuration.md)
  • Added YDB_PDISK_SIZE entry to Russian documentation (ydb/docs/ru/core/reference/docker/configuration.md)
  • Extended code implementation to support KB, MB, TB suffixes in addition to the existing GB suffix (ydb/tests/library/harness/kikimr_config.py)
  • Updated documentation to reflect all supported size suffixes

Variable details:

Original prompt

This section details on the original issue you should resolve

<issue_title>absent YDB_PDISK_SIZE env in documentation https://ydb.tech/docs/ru/reference/docker/configuration</issue_title>
<issue_description>https://github.com/ydb-platform/ydb/blob/main/ydb/docs/en/core/reference/docker/configuration.md
https://github.com/ydb-platform/ydb/blob/main/ydb/docs/ru/core/reference/docker/configuration.md</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@github-actions
Copy link

github-actions bot commented Nov 14, 2025

Hi! Thank you for contributing!
The tests on this PR will run after a maintainer adds an ok-to-test label to this PR manually. Thank you for your patience!

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

🟢 2025-11-20 18:27:33 UTC The validation of the Pull Request description is successful.

@asmyasnikov
Add YDB_PDISK_SIZE env variable to Docker configuration docs
4a13e89 
Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
@asmyasnikov asmyasnikov marked this pull request as ready for review November 14, 2025 16:49
@asmyasnikov asmyasnikov requested a review from a team as a code owner November 14, 2025 16:49
Copilot AI review requested due to automatic review settings November 14, 2025 16:49
Copilot AI changed the title [WIP] Fix absent YDB_PDISK_SIZE env in documentation Add missing YDB_PDISK_SIZE environment variable to Docker configuration documentation Nov 14, 2025
Copilot AI requested a review from asmyasnikov November 14, 2025 16:49
Copilot finished work on behalf of asmyasnikov November 14, 2025 16:49
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 14, 2025
Copilot finished reviewing on behalf of asmyasnikov November 14, 2025 16:51
Copilot AI reviewed Nov 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds documentation for the previously undocumented YDB_PDISK_SIZE environment variable to both English and Russian Docker configuration pages. The variable controls the physical disk size for YDB and defaults to 64GB.

  • Added YDB_PDISK_SIZE environment variable documentation
  • Documented that it accepts string (with "GB" suffix) or integer (bytes) values
  • Included the 64GB default value and usage examples

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ydb/docs/en/core/reference/docker/configuration.md Added YDB_PDISK_SIZE documentation entry to the English environment variables table
ydb/docs/ru/core/reference/docker/configuration.md Added YDB_PDISK_SIZE documentation entry to the Russian environment variables table

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@asmyasnikov asmyasnikov requested a review from zinal November 14, 2025 16:55
@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 14, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 14, 2025
@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 17:25:24 UTC Pre-commit check linux-x86_64-release-asan for 91ac923 has started.
⚪ 2025-11-14 17:25:41 UTC Artifacts will be uploaded here
⚫ 2025-11-14 17:27:54 UTC Check cancelled

@github-actions
Copy link

github-actions bot commented Nov 14, 2025 •
edited
Loading

⚪ 2025-11-14 17:25:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for 91ac923 has started.
⚪ 2025-11-14 17:26:13 UTC Artifacts will be uploaded here
⚫ 2025-11-14 17:27:51 UTC Check cancelled

asmyasnikov
asmyasnikov reviewed Nov 14, 2025
View reviewed changes
asmyasnikov
asmyasnikov reviewed Nov 14, 2025
View reviewed changes
asmyasnikov
asmyasnikov reviewed Nov 14, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (27)

⚠️ Title not found: bridge_config.md in ru/devops/configuration-management/configuration-v1/static-config.md

⚠️ Title not found: bridge_config.md in ru/devops/configuration-management/configuration-v2/config-settings.md

⚠️ Title not found: bridge_config.md in ru/reference/configuration/index.md

⚠️ en/concepts/analytics/concepts/etl.md: 49: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]

⚠️ en/concepts/analytics/concepts/ml.md: 16: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 3]

⚠️ en/concepts/analytics/concepts/ml.md: 17: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 3]

⚠️ en/concepts/analytics/concepts/store.md: 10: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ en/concepts/analytics/concepts/store.md: 9: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 13: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 23: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 27: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 38: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 40: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 46: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 58: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Log was truncated. (12 records)

asmyasnikov
asmyasnikov reviewed Nov 14, 2025
View reviewed changes
@asmyasnikov asmyasnikov enabled auto-merge (squash) November 17, 2025 15:52
@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 17, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 17, 2025
@github-actions
Copy link

github-actions bot commented Nov 17, 2025 •
edited
Loading

⚪ 2025-11-17 15:55:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for f8e867c has started.
⚪ 2025-11-17 15:56:18 UTC Artifacts will be uploaded here
⚪ 2025-11-17 15:58:15 UTC ya make is running...
🟢 2025-11-17 15:58:21 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-17 15:58:26 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 17, 2025 •
edited
Loading

⚪ 2025-11-17 15:56:27 UTC Pre-commit check linux-x86_64-release-asan for f8e867c has started.
⚪ 2025-11-17 15:57:05 UTC Artifacts will be uploaded here
⚪ 2025-11-17 15:59:49 UTC ya make is running...
🟢 2025-11-17 15:59:55 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-17 16:00:01 UTC Build successful.

fomichev3000
fomichev3000 requested changes Nov 17, 2025
View reviewed changes
asmyasnikov
asmyasnikov reviewed Nov 19, 2025
View reviewed changes
asmyasnikov
asmyasnikov reviewed Nov 19, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (27)

⚠️ Title not found: bridge_config.md in ru/devops/configuration-management/configuration-v1/static-config.md

⚠️ Title not found: bridge_config.md in ru/devops/configuration-management/configuration-v2/config-settings.md

⚠️ Title not found: bridge_config.md in ru/reference/configuration/index.md

⚠️ en/concepts/analytics/concepts/etl.md: 49: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 3]

⚠️ en/concepts/analytics/concepts/ml.md: 16: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 3]

⚠️ en/concepts/analytics/concepts/ml.md: 17: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 3]

⚠️ en/concepts/analytics/concepts/store.md: 10: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ en/concepts/analytics/concepts/store.md: 9: MD030 / list-marker-space Spaces after list markers [Expected: 1; Actual: 2]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 13: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 23: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 27: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 38: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 40: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 46: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

⚠️ ru/contributor/documentation/guide-to-public-material.md: 58: MD009 / no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

Log was truncated. (12 records)

@asmyasnikov
Add support for KB, MB, TB suffixes to YDB_PDISK_SIZE
9baf82d 
Co-authored-by: asmyasnikov <14202262+asmyasnikov@users.noreply.github.com>
auto-merge was automatically disabled November 20, 2025 18:23

Head branch was pushed to by a user without write access

Copilot AI changed the title Add missing YDB_PDISK_SIZE environment variable to Docker configuration documentation Add YDB_PDISK_SIZE environment variable with KB/MB/GB/TB suffix support Nov 20, 2025
Copilot AI requested a review from asmyasnikov November 20, 2025 18:25
Copilot finished work on behalf of asmyasnikov November 20, 2025 18:25
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Nov 20, 2025
@asmyasnikov asmyasnikov added the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 20, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 20, 2025
@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

⚪ 2025-11-20 18:58:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for 864cc94 has started.
⚪ 2025-11-20 18:58:55 UTC Artifacts will be uploaded here
⚪ 2025-11-20 19:01:13 UTC ya make is running...
🟡 2025-11-20 19:50:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6646 6491 0 2 136 17

⚪ 2025-11-20 19:50:56 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-20 20:04:40 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
43 (only retried tests) 34 0 0 0 9

🟢 2025-11-20 20:04:48 UTC Build successful.
🟢 2025-11-20 20:05:08 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f693412 merge: 864cc94 diff diff %
ydbd size 2 452 584 232 Bytes 2 452 584 232 Bytes 0 Bytes 0.000%
ydbd stripped size 521 518 136 Bytes 521 518 136 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

⚪ 2025-11-20 18:59:18 UTC Pre-commit check linux-x86_64-release-asan for 864cc94 has started.
⚪ 2025-11-20 18:59:36 UTC Artifacts will be uploaded here
⚪ 2025-11-20 19:01:45 UTC ya make is running...
🟡 2025-11-20 19:42:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1871 1855 0 5 6 5

🟢 2025-11-20 19:42:38 UTC Build successful.
🟢 2025-11-20 19:43:00 UTC ydbd size 3.8 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: f693412 merge: 864cc94 diff diff %
ydbd size 4 106 666 152 Bytes 4 106 666 152 Bytes 0 Bytes 0.000%
ydbd stripped size 1 525 426 320 Bytes 1 525 426 320 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@asmyasnikov asmyasnikov added documentation Improvements or additions to documentation ok-to-test Special label used to approve a PR for testing on our infrastructure labels Nov 26, 2025
@github-actions github-actions bot removed the ok-to-test Special label used to approve a PR for testing on our infrastructure label Nov 26, 2025
@github-actions
Copy link

github-actions bot commented Nov 26, 2025 •
edited
Loading

⚪ 2025-11-26 11:40:35 UTC Pre-commit check linux-x86_64-relwithdebinfo for 333907b has started.
⚪ 2025-11-26 11:40:52 UTC Artifacts will be uploaded here
⚪ 2025-11-26 11:43:01 UTC ya make is running...
🟡 2025-11-26 12:31:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
6749 6603 0 2 131 13

⚪ 2025-11-26 12:31:19 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-11-26 12:44:55 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29 (only retried tests) 23 0 0 0 6

🟢 2025-11-26 12:45:02 UTC Build successful.
🟢 2025-11-26 12:45:26 UTC ydbd size 2.3 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 462c794 merge: 333907b diff diff %
ydbd size 2 456 362 792 Bytes 2 456 362 792 Bytes 0 Bytes 0.000%
ydbd stripped size 523 441 336 Bytes 523 441 336 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Nov 26, 2025 •
edited
Loading

⚪ 2025-11-26 11:40:38 UTC Pre-commit check linux-x86_64-release-asan for 333907b has started.
⚪ 2025-11-26 11:40:55 UTC Artifacts will be uploaded here
⚪ 2025-11-26 11:43:04 UTC ya make is running...
🟡 2025-11-26 12:21:49 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1838 1808 0 14 6 10

🟢 2025-11-26 12:21:56 UTC Build successful.
🟢 2025-11-26 12:22:19 UTC ydbd size 3.8 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 462c794 merge: 333907b diff diff %
ydbd size 4 111 743 728 Bytes 4 111 743 632 Bytes -96 Bytes -0.000%
ydbd stripped size 1 528 202 992 Bytes 1 528 202 928 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@polRk polRk polRk approved these changes

@zinal zinal zinal left review comments

@fomichev3000 fomichev3000 Awaiting requested review from fomichev3000

+1 more reviewer

@asmyasnikov asmyasnikov asmyasnikov approved these changes

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@asmyasnikov asmyasnikov

Copilot code review Copilot

Labels

documentation Improvements or additions to documentation external

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

absent YDB_PDISK_SIZE env in documentation https://ydb.tech/docs/ru/reference/docker/configuration

5 participants

@fomichev3000 @zinal @asmyasnikov @polRk