Skip to content

Fix CodeQL findings in GitHub Actions workflows - #946

Open
vgvoleg wants to merge 2 commits into
mainfrom
ci/fix-codeql-actions-alerts
Open

vgvoleg wants to merge 2 commits into
mainfrom
ci/fix-codeql-actions-alerts

Conversation

@vgvoleg

@vgvoleg vgvoleg commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Limit the default GITHUB_TOKEN permissions in the test, style, and release workflows, and pin Codecov, Sphinx Pages, and the two SLO actions to the commits currently selected by their version tags.

Prepare the SLO baseline as a detached worktree at the merge base with origin/main. The workload workflow uses a read-only token, while the separate reporting workflow retains the permissions needed to publish results.

Align the SLO OpenTelemetry SDK and OTLP exporter with the API version already pinned at 1.45.1. The previous SDK required API 1.39.1, so pip could not build the workload images.

@vgvoleg vgvoleg added the SLO label Nov 20, 2026
@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.70%. Comparing base (a1e8d26) to head (3589d0d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   82.73%   82.70%   -0.03%     
==========================================
  Files          99       99              
  Lines       12965    12965              
  Branches     1266     1266              
==========================================
- Hits        10726    10723       -3     
- Misses       1788     1789       +1     
- Partials      451      453       +2     
Flag Coverage Δ
integration 80.40% <ø> (-0.03%) ⬇️
unit 49.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot removed the SLO label Nov 20, 2026
@vgvoleg vgvoleg added the SLO label Nov 20, 2026
@github-actions github-actions Bot removed the SLO label Nov 20, 2026
@vgvoleg vgvoleg added the SLO label Nov 20, 2026
@github-actions github-actions Bot removed the SLO label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

🌋 SLO Test Results

🟡 5 workload(s) tested — 1 workload(s) exceeded warning thresholds

Commit: f9681c3 · View run

Workload Thresholds Duration Report
sync-query 🟢 OK 10m 25s 📄 Report
sync-topic 🟢 OK 10m 8s 📄 Report
async-query 🟡 Warning 10m 44s 📄 Report
async-topic 🟢 OK 10m 2s 📄 Report
sync-table 🟢 OK 10m 2s 📄 Report

Threshold violations:

async-query:

  • read_retry_attempts: ▲ 40.0% (≥ 20% warn)

Generated by ydb-slo-action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant