Repository navigation
fix: keep inline span text separated - #201
Closed
mayankdhingra02 wants to merge 1 commit into
Closed
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Require a separating space when the next row has visible text. Decide whether it fits after assembling the complete row, so empty leading columns cannot hide the span before that check. Preserve empty rows and spans, and append multi-column rows only once when wrapping is disabled. Add plain, ANSI and wide-text regressions. Closes yargs#88 Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
Member
|
Unsolicited Pull Requests may be closed without discussion. For more see Contributing and AI Policy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #88.
When span text fills the space before the next row, the two pieces of
text currently run together, such as
1234567890[boolean]. Start a newline when there is no room for a separating space, while preserving
empty spans and empty following rows.
Check the complete row before merging it into a span. This also handles
empty leading columns and avoids repeating the span prefix for each
column when wrapping is disabled.
Validation on Node 24: all 34 tests pass, including eight new boundary
and compatibility cases. The plain, ANSI and wide-text regressions fail
before the fix.
npm run checkandnpm run coveragepass (100% linesand statements, 97.4% branches).