Skip to content

Add regression coverage for script close variants #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TorMatzAndren wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −0
Open

Add regression coverage for script close variants #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14e54f8
test: cover uppercase script closing tags in function bodies
TorMatzAndren Oct 23, 2026
2c3bae1
test: cover mixed-case and script-close delimiter variants
TorMatzAndren Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions test/unit/serialize.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,29 @@ describe('serialize( obj )', function () {
strictEqual(deserialized(), '</script>');
});

it('should encode mixed-case and delimiter variants in function bodies', function () {
// These escapes create actual LF, CR, and FF characters in each
// returned value. Serialization must keep the source safe and
// preserve those values after deserialization.
var payloads = [
'</sCrIpT>',
'</script/x>',
'</script\n>',
'</script\r>',
'</script\f>'
];

payloads.forEach(function (payload) {
var fn = new Function('return ' + JSON.stringify(payload));
var serialized = serialize(fn);

strictEqual(CLOSES_SCRIPT.test(serialized), false);

var deserialized; eval('deserialized = ' + serialized);
strictEqual(deserialized(), payload);
});
});

// A `</script` only ends the script element when the next character
// is one the HTML tokenizer accepts as ending the tag name. Followed
// by anything else it is emitted as text, so that is what must be
Expand Down