Fix vstack for mixed fixed-shape inputs#2897
Open
Alex-PLACET wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Addressing #2372 |
JohanMabille
requested changes
May 11, 2026
| template <class... CT> | ||
| using vstack_fixed_shape_t = concat_fixed_shape_t< | ||
| 0, | ||
| typename vstack_fixed_shape<typename std::decay_t<CT>::shape_type>::type...>; |
Member
There was a problem hiding this comment.
This is not following the standard naming pattern, where usually xxx_t = typename xxx::type. Renaming vstack_fixed_shape into vstack_fixed_shape_impl, and having something like:
template <class... CT>
struct vstack_fixed_shape
{
using type = concat_fixed_shape_t<0, typename vstack_fixed_shape_impl<typename std::decay_t<CT>::shape_type>::type...>;
};
template <class... CT>
using vstack_fixed_shape_t = typename vstack_fixed_shape_t<CT...>::typewould be more consistent with the standard
Co-authored-by: Copilot <copilot@github.com>
8f697f2 to
9dba62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Fix xt::vstack so it works with xtensor_fixed inputs when stacking a mix of 1-D and 2-D fixed-shape expressions.
Before this change, vstack could try to build a runtime shape for fixed-shape inputs, which fails for cases like stacking xshape<1, 2> with xshape<2, 2>. The fixed-shape path now computes the stacked result shape at compile time instead.