Enable the ARM64 target on the ARM64EC ABI. - #1408
Open
degasus wants to merge 3 commits into
Open
Conversation
Contributor
|
LGTM. This does mean we should add that architecture to our CI target, can you give it a try? |
ARM64EC enables both _M_AMD64 and _M_ARM64EC. We already exclude ARM64EC from the SSE2 detection, but it was missing for the X64 target detection. However we're now fine to enable the ARM64 target. At least my kernels compile fine (as good as on the raw arm64) on MSVC. Related: https://techcommunity.microsoft.com/blog/windowsosplatform/getting-to-know-arm64ec-defines-and-intrinsic-functions/2957235
I assume the /MANIFAST:NO shall be added as LDFLAGS, not overwrite it. So keep the old LDFLAGS.
Contributor
Author
Done. CMake's recormendation seems to be to provide The strangest issue I had with the test is the git's msys2 envvar handling: When calling cmake (native) from bash (msys2), it converts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM64EC enables both _M_AMD64 and _M_ARM64EC. We already exclude ARM64EC from the SSE2 detection, but it was missing for the X64 target detection (by me in #1152, apparently on purpose).
However we're now fine to enable the ARM64 target. At least my kernels compile fine (as good as on the native arm64) on MSVC.
Related: https://techcommunity.microsoft.com/blog/windowsosplatform/getting-to-know-arm64ec-defines-and-intrinsic-functions/2957235
Tested on a local Windows arm64 machine with the arm64ec ABI:
now:
before enabling XSIMD_TARGET_ARM64: