Repository navigation
Carry rounded lengths into kilometres - #88
Open
machines-6657 wants to merge 1 commit into
Open
machines-6657 wants to merge 1 commit into
machines-6657 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix format_length() rounding into the next unit
Problem
format_length()chooses a unit before rounding its value to two decimal places. As a result, a supported length such as999.999metres is rendered as1000 metres, even though the rounded quantity is exactly1 kmand that unit is supported.Change
After rounding, carry into the next larger supported length unit when the rounded value reaches its divider. Add a regression assertion for the metre-to-kilometre boundary.
Validation
1000 metresinstead of1 km), passes after it.HOME, hard-codedbash, and Unix-onlytermiosdependencies.flake8, Python compilation, andgit diff --checkpass.